Add ninja as a default build system for some runners. #4491
Conversation
fruffy
added
the
infrastructure
fruffy
force-pushed
the
fruffy/build_system
branch
8 times, most recently
from
6936c66
to
86cb892
Compare
fruffy
force-pushed
the
fruffy/build_system
branch
6 times, most recently
from
74bb58e
to
c0b95ed
Compare
fruffy
force-pushed
the
fruffy/build_system
branch
2 times, most recently
from
71eea42
to
99a324b
Compare
There was a problem hiding this comment.
Is there a build that uses make now? I don't see any and I think it is a good idea to have one. Ubuntu unity could be a good candidate as it should be relatively fast anyway as a unity build. The non-unity could be an alternative if the speed is of concern as it does not run tests (it is hard, but not impossible, to imagine a different build system to cause bugs in the build).
fruffy
force-pushed
the
fruffy/build_system
branch
from
99a324b
to
94a6118
Compare
I figured we could use the nightly sanitizer build for this: https://github.com/p4lang/p4c/blob/main/.github/workflows/ci-ubuntu-20-sanitizer-nightly.yml I can also change the unity build to use make again. |
|
OK, I think having make just in nightly would be sufficient, I am OK with either of these choices. |
fruffy
force-pushed
the
fruffy/build_system
branch
from
77ba1de
to
6bbbfbd
Compare
Fixes #4471.
Needs a bit more work. There are lot of different build systems and options scattered around.